[charts] Fix tooltip follow mouse #15189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
bug 🐛
|
Deploy preview: https://deploy-preview-15189--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #15189 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed The #15003 introduced a bug. It does not properly update the tootlip position outside of react render.
You can see that on pie chart in the buggy PR preview https://deploy-preview-15003--material-ui-x.netlify.app/x/react-charts/pie/
buggy-pie.mp4
This PR fix it. I don't know why, but using a
ref.currentinanchorEldoes not work, so I copied the behavior of the MUI Tooltip followCursor propThis PR preview: https://deploy-preview-15189--material-ui-x.netlify.app/x/react-charts/pie/