-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Remove deprecated highlight properties #15191
Conversation
Deploy preview: https://deploy-preview-15191--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #15191 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to add a section to the migration guide?
And maybe a codemod?
@flaviendelangle This issue with codemod is that it's nested properties. So I assume (at least that's how I would do it in my apps) that those definition are made outside. So a codemod would catch few usecases. Yes for the migration guide, but I will open a dedicated PR for all the renaming we merged this week #15276 |
Changelog
The
highlighted
andfaded
properties of highlightScope were deprecated in favor ofhighlight
andfade
.The deprecated ones are now removed.