Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Set default overlay height in flex parent layout #15202

Merged
merged 6 commits into from
Nov 5, 2024
Merged

[DataGrid] Set default overlay height in flex parent layout #15202

merged 6 commits into from
Nov 5, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Oct 30, 2024 •
edited
Loading

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge labels Oct 30, 2024
@mui-bot
Copy link

mui-bot commented Oct 30, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15202--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 5879653

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2024
This was referenced Oct 31, 2024
Closed
Closed
@cherniavskii cherniavskii marked this pull request as ready for review October 31, 2024 16:39
@cherniavskii cherniavskii requested a review from a team October 31, 2024 16:39
@KenanYusuf KenanYusuf merged commit 8acff87 into mui:master Nov 5, 2024
18 checks passed
@serrg
Copy link

serrg commented Nov 20, 2024

Is it possible to set a default overlay height within a flex parent layout using MUI v6?

We can set it manually like:

sx={{
  "& .MuiDataGrid-overlayWrapper": {
    minHeight: "104px", // Set your desired default height
  },
}}

but this change will also impact other overlays.

@cherniavskii cherniavskii deleted the flex-parent-minimum-overlay-height branch November 21, 2024 12:38
@cherniavskii
Copy link
Member Author

Is it possible to set a default overlay height within a flex parent layout using MUI v6?

@serrg I'm not sure the flex parent layout works correctly in Data Grid v6.

but this change will also impact other overlays.

I think this is expected, it impacts all overlays.

cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Nov 21, 2024
@cherniavskii
[DataGrid] Set default overlay height in flex parent layout (mui#15202)
397b62c
@cherniavskii cherniavskii mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanYusuf KenanYusuf KenanYusuf approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] DataGrid "no rows" overlay missing when autoHeight=true
4 participants
@cherniavskii @mui-bot @serrg @KenanYusuf