Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix "No rows" displaying when all rows are pinned #15335

Merged
merged 7 commits into from
Dec 11, 2024
Merged

[DataGrid] Fix "No rows" displaying when all rows are pinned #15335

merged 7 commits into from
Dec 11, 2024

Conversation

nusr
Copy link
Contributor

@nusr nusr commented Nov 8, 2024 •
edited
Loading

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Nov 8, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@zannager zannager requested a review from KenanYusuf December 11, 2024 13:41
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 11, 2024
@KenanYusuf KenanYusuf added bug 🐛 Something doesn't work feature: Row pinning Related to the data grid Row pinning feature labels Dec 11, 2024
@KenanYusuf KenanYusuf changed the title Fix no rows [DataGrid] Fix "No rows" displaying when all rows are pinned Dec 11, 2024
@mui-bot
Copy link

mui-bot commented Dec 11, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15335--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1b9b480

@KenanYusuf KenanYusuf added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 11, 2024
@KenanYusuf KenanYusuf merged commit 46c46ff into mui:master Dec 11, 2024
22 checks passed
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@nusr @KenanYusuf @web-flow
[DataGrid] Fix "No rows" displaying when all rows are pinned (#15335)
e61283d 
Signed-off-by: Steve Xu <stevexugc@gmail.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Merged
lauri865 pushed a commit to lauri865/mui-x that referenced this pull request Dec 19, 2024
@nusr @KenanYusuf @lauri865
[DataGrid] Fix "No rows" displaying when all rows are pinned (mui#15335)
aaec733 
Signed-off-by: Steve Xu <stevexugc@gmail.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@nusr @KenanYusuf @LukasTy
[DataGrid] Fix "No rows" displaying when all rows are pinned (mui#15335)
983dde6 
Signed-off-by: Steve Xu <stevexugc@gmail.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanYusuf KenanYusuf KenanYusuf approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row pinning Related to the data grid Row pinning feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] noRowsOverlay displays when all rows are pinned
4 participants
@nusr @mui-bot @KenanYusuf @zannager