React 19 support #15342
Merged
React 19 support #15342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
component: data grid
|
Deploy preview: https://deploy-preview-15342--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #15342 will improve performances by 12.5%Comparing Summary
Benchmarks breakdown
|
arminmeh
requested review from
LukasTy,
cherniavskii,
flaviendelangle and
alexfauquette
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
flaviendelangle
force-pushed
the
react-19
branch
from
7b27228 to
a16f8da
Compare
arminmeh
force-pushed
the
react-19
branch
2 times, most recently
from
e5156af to
3403086
Compare
arminmeh
added
needs cherry-pick
|
I also did a manual test |
LukasTy
approved these changes
Nov 21, 2024
| steps: | ||
| - run: | ||
| name: Install @mui/material@next | ||
| name: Install @mui/material v6 |
test/utils/pickers/describeValue/testPickerOpenCloseLifeCycle.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com> Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
flaviendelangle
approved these changes
Nov 22, 2024
cherniavskii
approved these changes
Nov 22, 2024
|
Cherry-pick PRs will be created targeting branches: v7.x |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Co-authored-by: flavien <flaviendelangle@gmail.com> Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com> Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Merged
LukasTy
added a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Co-authored-by: flavien <flaviendelangle@gmail.com> Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com> Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13356
To run locally, after checkout run
pnpm use-react-version rc && pnpm use-material-ui-v6(since v5 does not support r19)All checks are ✅
building the packages works finesome tests are still failing (would appreciate if someone from @mui/explore would look at the one with datepicker)Test updates done in a same way and for the same reasons as in
mui/material-ui#43155