-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][data grid] Add documentation for the list view feature #15344
Conversation
Deploy preview: https://deploy-preview-15344--material-ui-x.netlify.app/ Updated pages: |
You need to apply these changes in the index 51eb1f82e..322d1c78f 100644
--- a/docs/scripts/formattedTSDemos.js
+++ b/docs/scripts/formattedTSDemos.js
@@ -9,7 +9,7 @@
* List of demos to ignore when transpiling
* Example: "app-bar/BottomAppBar.tsx"
*/
-const ignoreList = ['/pages.ts', 'styling.ts', 'styling.tsx'];
-const ignoreList = ['/pages.ts', 'styling.ts', 'styling.tsx'];
+const ignoreList = ['/pages.ts', 'styling.ts', 'styling.tsx', 'types.ts'];
const fs = require('fs');
const fse = require('fs-extra');
@@ -55,7 +55,8 @@ async function getFiles(root) {
files.push(...(await getFiles(filePath)));
} else if (
stat.isFile() &&
- filePath.endsWith('.tsx') &&
+ /\.tsx?$/.test(filePath) &&
+ !filePath.endsWith('.d.ts') &&
!ignoreList.some((ignorePath) => filePath.endsWith(path.normalize(ignorePath)))
) {
files.push(filePath);
@@ -79,7 +80,7 @@ const TranspileResult = {
};
async function transpileFile(tsxPath, program, ignoreCache = false) {
- const jsPath = tsxPath.replace('.tsx', '.js');
+ const jsPath = tsxPath.replace('.tsx', '.js').replace('.ts', '.js');
try {
if (!ignoreCache && (await fse.exists(jsPath))) {
: I tried this locally, but it transpiles more files, can you double check if this is expected? We may need to add more items in the |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@samuelsycamore thanks for the review! I made a few more changes to the column definition prop descriptions, would you mind taking another look? 🙏 https://github.com/mui/mui-x/pull/15344/files#diff-e6ca07fd0bb0e954721c94acb249fb8c021cc559155fa0496b331cc20bff1802 |
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Massive improvement @KenanYusuf !
packages/x-data-grid/src/hooks/features/listView/gridListViewSelectors.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
packages/x-data-grid/src/hooks/features/listView/gridListViewSelectors.ts
Show resolved
Hide resolved
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I've pushed just 2 minor commits: 32e92a0
(#15344), 6356ab4
(#15344)
#15635) Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com> Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
Closes #14996
Closes #6460