Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimePicker] Prevent mouse events after touchend event #15346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arthurbalduini
Copy link
Member

@arthurbalduini arthurbalduini commented Nov 8, 2024

Closes #15338

After the introduction of #14305 the addition of touchStart causes touchEnd event to trigger mouse events leading to the bug reported.
Unfortunately the test environment does not simulate this behavior, otherwise it would have been catched by this test

Since we do not expose the event handlers on this component, I wouldn't expect issues on preventing this behavior that is, although a bit weird, the correct one.

Could be cherry-picked to v7

@arthurbalduini arthurbalduini added the component: pickers This is the name of the generic UI component, not the React module! label Nov 8, 2024
@arthurbalduini arthurbalduini changed the title [pickers] Add flag to prevent mouse events on touch devices [pickers] Prevent mouse events after touchEnd Nov 8, 2024
@arthurbalduini arthurbalduini changed the title [pickers] Prevent mouse events after touchEnd [pickers] Prevent mouse events after touchend event Nov 8, 2024
@arthurbalduini arthurbalduini added the needs cherry-pick The PR should be cherry-picked to master after merge label Nov 8, 2024
@mui-bot
Copy link

mui-bot commented Nov 8, 2024

Deploy preview: https://deploy-preview-15346--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against eaf4296

@LukasTy LukasTy changed the title [pickers] Prevent mouse events after touchend event [TimePicker] Prevent mouse events after touchend event Nov 12, 2024
@LukasTy LukasTy added regression A bug, but worse component: TimePicker The React component. v7.x labels Nov 12, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling it. 🙏
Added labels that made sense to me. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. needs cherry-pick The PR should be cherry-picked to master after merge regression A bug, but worse v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TimeClock] The TimeClock selects the same minutes when selecting the hour
4 participants