Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTimeRangePicker] Use time in referenceDate when selecting date #15429

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[DateTimeRangePicker] Use time in referenceDate when selecting date #15429

merged 2 commits into from
Nov 15, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Nov 15, 2024

Fixes #15405.

@LukasTy LukasTy added bug 🐛 Something doesn't work plan: Pro Impact at least one Pro user component: pickers This is the name of the generic UI component, not the React module! cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch v7.x component: DateTimeRangePicker The React component labels Nov 15, 2024
@LukasTy LukasTy self-assigned this Nov 15, 2024
michelengelen
michelengelen approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mui-bot
Copy link

mui-bot commented Nov 15, 2024

Deploy preview: https://deploy-preview-15429--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 375b769

flaviendelangle
flaviendelangle approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix 👌

@LukasTy LukasTy merged commit a204305 into mui:master Nov 15, 2024
30 checks passed
@LukasTy LukasTy deleted the fix-dtr-reference-date-usage branch November 15, 2024 10:18
@LukasTy LukasTy added needs cherry-pick The PR should be cherry-picked to master after merge and removed cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch labels Nov 15, 2024
LukasTy added a commit to LukasTy/mui-x that referenced this pull request Nov 15, 2024
@LukasTy
[DateTimeRangePicker] Use time in referenceDate when selecting date (…
c49d5b3 
…mui#15429)
@LukasTy LukasTy mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@arthurbalduini arthurbalduini Awaiting requested review from arthurbalduini

Assignees

@LukasTy LukasTy

Labels
bug 🐛 Something doesn't work component: DateTimeRangePicker The React component component: pickers This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge plan: Pro Impact at least one Pro user v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers][DateTimeRangePicker] Issue with setting initial time values
4 participants
@LukasTy @mui-bot @flaviendelangle @michelengelen