Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Remove rowPositionsDebounceMs prop #15482

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Nov 19, 2024

Closes #15480

Changelog

Breaking changes

  • The rowPositionsDebounceMs prop was removed.

@mui-bot
Copy link

mui-bot commented Nov 19, 2024

@k-rajat19 k-rajat19 changed the title [DataGridPro] Remove rowPositionsDebounceMs prop [DataGrid] Remove rowPositionsDebounceMs prop Nov 19, 2024
@k-rajat19 k-rajat19 marked this pull request as ready for review November 19, 2024 14:04
@romgrk romgrk added breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x labels Nov 19, 2024
Copy link
Contributor

@arminmeh arminmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-rajat19 you have to add changelog entry for the breaking change and to update the migration guide stating that this API is removed

You can use #15523 as a guidance

@romgrk
Copy link
Contributor

romgrk commented Dec 2, 2024

Right, but just the migration guide no? The changelog is autogenerated from PRs.

@arminmeh
Copy link
Contributor

arminmeh commented Dec 2, 2024

Right, but just the migration guide no? The changelog is autogenerated from PRs.

Yeah, I meant to add Changelog in the PR description, not in the file.
Didn't explain that properly 😅

@arminmeh arminmeh enabled auto-merge (squash) December 4, 2024 11:49
@arminmeh
Copy link
Contributor

arminmeh commented Dec 4, 2024

@k-rajat19 I did the necessary updates and approved the PR

@arminmeh arminmeh merged commit c226261 into mui:master Dec 4, 2024
16 checks passed
@k-rajat19 k-rajat19 deleted the issue-15480 branch December 7, 2024 09:04
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
Co-authored-by: Armin Mehinovic <armin@mui.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Remove the rowPostionsDebounceMs prop
4 participants