[DataGridPro] Fix header filtering with boolean column type
#15528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15528--material-ui-x.netlify.app/ |
packages/x-data-grid-pro/src/components/headerFiltering/GridHeaderFilterCell.tsx
Show resolved
Hide resolved
| @@ -314,7 +314,7 @@ const GridHeaderFilterCell = React.forwardRef<HTMLDivElement, GridHeaderFilterCe | |||
|
|
|||
| const isNoInputOperator = currentOperator.requiresFilterValue === false; | |||
|
|
|||
| const isApplied = Boolean(item?.value) || isNoInputOperator; | |||
| const isApplied = item?.value !== undefined || isNoInputOperator; | |||
There was a problem hiding this comment.
same here
Suggested change
| const isApplied = item?.value !== undefined || isNoInputOperator; | |
| const isApplied = item?.value != undefined || isNoInputOperator; |
michelengelen
added
bug 🐛
|
all right ... I'll let @arminmeh as the main reviewer approve this! 👍🏼 |
arminmeh
approved these changes
Nov 22, 2024
|
@k-rajat19 should this be merged? We usually wait for the contributors to merge their own PRs (in case there is still something that they had in mind) |
|
All good from my side, you can merge it |
arminmeh
added
needs cherry-pick
arminmeh
pushed a commit
that referenced
this pull request
Nov 27, 2024
1 task
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15524
Related to #15252
Preview - https://deploy-preview-15528--material-ui-x.netlify.app/x/react-data-grid/filtering/header-filters/