Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Dutch (nl-NL) locale #15564

Merged
merged 4 commits into from
Nov 23, 2024
Merged

Conversation

nphmuller
Copy link
Contributor

@nphmuller nphmuller commented Nov 22, 2024

  • Update placeholders from:
    • Y (Year) to J (Jaar)
    • hh (Hour) to uu (Uur)
  • Fix compound words: Words like start date are a single word in dutch (startdatum).
  • The translation key empty indicates an empty state, not the verb "to empty". It's used for aria-valuetext to indicate an empty value.

Signed-off-by: Nick Muller <3781551+nphmuller@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Nov 22, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-15564--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ceb39ad

@oliviertassinari oliviertassinari added the l10n localization label Nov 23, 2024
@oliviertassinari oliviertassinari merged commit 419eb67 into mui:master Nov 23, 2024
20 checks passed
@nphmuller nphmuller deleted the patch-1 branch November 23, 2024 12:24
@nphmuller
Copy link
Contributor Author

@oliviertassinari would it make sense to cherry pick these changes to the v7 branch? It might take a while before v8 wil be released right?

oliviertassinari pushed a commit that referenced this pull request Nov 23, 2024
Signed-off-by: Nick Muller <3781551+nphmuller@users.noreply.github.com>
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 23, 2024

@nphmuller We target the release of v8 in March 2025, proof: https://mui.com/blog/mui-x-v8-alpha-zero/. Ok, commit cherry-picked, proof: d72dd79.

Thanks for the fix.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Nov 23, 2024
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
Signed-off-by: Nick Muller <3781551+nphmuller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants