[charts] Flatten imports from @mui/utils and @mui/system
#15603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-15603--material-ui-x.netlify.app/ |
| @@ -12,7 +12,6 @@ import { ChartsAxisHighlight } from '@mui/x-charts/ChartsAxisHighlight'; | |||
| import { ChartsTooltip } from '@mui/x-charts/ChartsTooltip'; | |||
| import { ChartsClipPath } from '@mui/x-charts/ChartsClipPath'; | |||
| import { useBarChartProps } from '@mui/x-charts/internals'; | |||
| import { BarPlotProps } from '@mui/x-charts'; | |||
There was a problem hiding this comment.
The lint should catch that one no?
There was a problem hiding this comment.
I found why (thanks to npx eslint --print-config [file path] config.
Our config was such that it prevents you to do a root import of the package itself
CodSpeed Performance ReportMerging #15603 will improve performances by 41.03%Comparing Summary
Benchmarks breakdown
|
alexfauquette
force-pushed
the
flatten-imports
branch
from
1bcff76 to
a2d1353
Compare
JCQuintas
approved these changes
Nov 26, 2024
LukasTy
approved these changes
Nov 26, 2024
LukasTy
reviewed
Nov 26, 2024
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
LukasTy
added a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10354