Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Check if preset-safe folder exists in codemod test #15703

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas added bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product labels Dec 2, 2024
@JCQuintas JCQuintas requested a review from LukasTy December 2, 2024 18:09
@JCQuintas JCQuintas self-assigned this Dec 2, 2024
@mui-bot
Copy link

mui-bot commented Dec 2, 2024

Deploy preview: https://deploy-preview-15703--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c90bad5

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🙈

@LukasTy LukasTy merged commit d579d89 into mui:master Dec 3, 2024
22 checks passed
@arminmeh
Copy link
Contributor

arminmeh commented Dec 3, 2024

should it always be there?
I actually added a folder here #15709

@JCQuintas
Copy link
Member Author

should it always be there?
I actually added a folder here #15709

Not necessarily, you could have a package that has only "unsafe" codemods

LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants