[test] Force hover in headless Chrome #15710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15710--material-ui-x.netlify.app/ |
arminmeh
approved these changes
Dec 3, 2024
cherniavskii
added
needs cherry-pick
JCQuintas
approved these changes
Dec 3, 2024
|
Cherry-pick PRs will be created targeting branches: v7.x |
Yes, desktop Ubuntu has hover capabilities (mouse/trackpad). On the server, there's none. |
|
My point was that it ran on ubuntu headless (WSL) properly, but failed on osx headless 😅 |
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inconsistencies we had in a few tests, where tests were passing in CI, but failing locally or vice versa.
It turns out, that the headless Chrome in Circle CI had no hover capabilities, therefore it was applying
@media (hover: none)styles, while locally it applied@media (hover: hover)styles.Adding
primaryHoverType=2enables hover capabilities for the headless Chrome in CI.