Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Improve SVG pattern and gradient support #15720

Merged
merged 11 commits into from
Dec 4, 2024
Merged

[charts] Improve SVG pattern and gradient support #15720

merged 11 commits into from
Dec 4, 2024

Conversation

JCQuintas
Copy link
Member

Closes #15706

@JCQuintas JCQuintas added enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x component: charts This is the name of the generic UI component, not the React module! labels Dec 3, 2024
@JCQuintas JCQuintas self-assigned this Dec 3, 2024
@mui-bot
Copy link

mui-bot commented Dec 3, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15720--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 939448f

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 3, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #15720 will not alter performance

Comparing JCQuintas:fill-pie (939448f) with master (fa5f970)

Summary

✅ 6 untouched benchmarks

alexfauquette
alexfauquette reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice demo 👍

While reading it, I was wondering. If the tooltip marks were SVG elements instead of div, would they be able to access url?

If that's the case, it will simplify a lot the explanations. And we could keep a subsections explaining the CSS vars trick for those who have custom components with HTML using colors.

docs/data/charts/styling/styling.md Outdated Show resolved Hide resolved
packages/x-charts/src/PieChart/PieArc.tsx Outdated Show resolved Hide resolved
docs/data/charts/styling/styling.md Outdated Show resolved Hide resolved
docs/data/charts/styling/styling.md Outdated Show resolved Hide resolved
docs/data/charts/styling/styling.md Outdated Show resolved Hide resolved
@JCQuintas
Copy link
Member Author

While reading it, I was wondering. If the tooltip marks were SVG elements instead of div, would they be able to access url?

Yeah definitely, I thought about that before going sleep 😄

My plan is to do that for v8 only though, so I can make the new marker designs in svg

JCQuintas and others added 7 commits December 4, 2024 11:34
@JCQuintas @alexfauquette
Apply suggestions from code review
48be075 
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @alexfauquette
Apply suggestions from code review
a7a3756 
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas
remove obsolete example
b75c15f
@JCQuintas
fix styling
0194beb
@JCQuintas
Merge branch 'master' into fill-pie
39a67f3
@JCQuintas
use pattern transform to scale pattern
92efaec
@JCQuintas
scripts
939448f
@JCQuintas JCQuintas merged commit f9df87a into mui:master Dec 4, 2024
19 checks passed
@JCQuintas JCQuintas deleted the fill-pie branch December 4, 2024 11:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
@JCQuintas @alexfauquette @web-flow
[charts] Improve SVG pattern and gradient support (#15720)
feca5dd 
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@JCQuintas @alexfauquette @LukasTy
[charts] Improve SVG pattern and gradient support (mui#15720)
ed2bcce 
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[charts] Support for patterns in coloring PieChart
3 participants
@JCQuintas @mui-bot @alexfauquette