Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Fix group column ignoring valueOptions for singleSelect column type #15739

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Dec 5, 2024

Fixes #15717

Value formatters rely sometimes on the column definition.
Group column should use the original column's definition to format the value properly

Before: https://codesandbox.io/p/sandbox/valueoption-group-before-3zv4cv
After: https://codesandbox.io/p/sandbox/valueoption-group-after-cnf49r

@arminmeh arminmeh added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! plan: Premium Impact at least one Premium user feature: Row grouping Related to the data grid Row grouping feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 5, 2024
@arminmeh arminmeh requested a review from a team December 5, 2024 09:33
@mui-bot
Copy link

mui-bot commented Dec 5, 2024

Deploy preview: https://deploy-preview-15739--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8a67886

@cherniavskii cherniavskii merged commit 097aec1 into mui:master Dec 5, 2024
30 checks passed
Copy link

github-actions bot commented Dec 5, 2024

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@arminmeh arminmeh deleted the fix-grouped-row-formatted-value branch December 5, 2024 17:25
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row grouping Related to the data grid Row grouping feature needs cherry-pick The PR should be cherry-picked to master after merge plan: Premium Impact at least one Premium user v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Grouping by column of type singleSelect doesn't look up labels from valueOptions
3 participants