Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Make row spanning feature stable #15742

Merged
merged 6 commits into from
Dec 7, 2024
Merged

[DataGrid] Make row spanning feature stable #15742

merged 6 commits into from
Dec 7, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Dec 5, 2024 •
edited
Loading

Point no. 3 of #15488

ToDos:

  • Migration guide entry
  • Codemod

Changelog

Breaking changes

  • The feature "row spanning" is now stable. 
     <DataGrid
-  unstable_rowSpanning
+  rowSpanning
 />

@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x feature: Row spanning Related to the data grid Row spanning feature labels Dec 5, 2024
@mui-bot
Copy link

mui-bot commented Dec 5, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15742--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 91593f4

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 5, 2024
@MBilalShafi MBilalShafi requested a review from a team December 5, 2024 12:12
@MBilalShafi @arminmeh
Simplify the note
91593f4 
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
@MBilalShafi MBilalShafi merged commit 338eaad into mui:master Dec 7, 2024
18 checks passed
@MBilalShafi MBilalShafi deleted the bc/make-row-spanning-stable branch December 7, 2024 09:46
@arminmeh
Copy link
Contributor

arminmeh commented Dec 9, 2024

No codemod?

@MBilalShafi
Copy link
Member Author

No codemod?

Will add in a follow-up PR. Have a couple others too, it'll be simpler to add them together.

LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@MBilalShafi @arminmeh @LukasTy
[DataGrid] Make row spanning feature stable (mui#15742)
38aa5ba 
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBilalShafi @mui-bot @arminmeh