-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Remove PickersMonth
and PickersYear
from the theme and remove the div
wrapping each button
#15806
Merged
flaviendelangle
merged 21 commits into
mui:master
from
flaviendelangle:month-year-button
Dec 19, 2024
Merged
[pickers] Remove PickersMonth
and PickersYear
from the theme and remove the div
wrapping each button
#15806
flaviendelangle
merged 21 commits into
mui:master
from
flaviendelangle:month-year-button
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview: https://deploy-preview-15806--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
added
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
labels
Dec 9, 2024
flaviendelangle
changed the title
[pickers] Remove
[pickers] Remove Dec 13, 2024
PickersMonth
and PickersYear
from the theme and use display: grid
PickersMonth
and PickersYear
from the theme and remove the div
wrapping the buttons
flaviendelangle
changed the title
[pickers] Remove
[pickers] Remove Dec 13, 2024
PickersMonth
and PickersYear
from the theme and remove the div
wrapping the buttonsPickersMonth
and PickersYear
from the theme and remove the div
wrapping each button
flaviendelangle
force-pushed
the
month-year-button
branch
2 times, most recently
from
December 13, 2024 09:45
7e25a8a
to
5141c33
Compare
noraleonte
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort here 🚀
Leaving a few styling-related comments 🙈
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
flaviendelangle
commented
Dec 18, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
lauri865
pushed a commit
to lauri865/mui-x
that referenced
this pull request
Dec 19, 2024
…remove the `div` wrapping each button (mui#15806) Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14474
Changelog
Breaking changes
The
<PickersMonth />
component has been moved inside the Month Calendar component — Learn more.The
<PickersYear />
component has been moved inside the Year Calendar component — Learn more.