Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Remove PickersMonth and PickersYear from the theme and remove the div wrapping each button #15806

Merged
merged 21 commits into from
Dec 19, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Dec 9, 2024

Closes #14474

Changelog

Breaking changes

  • The <PickersMonth /> component has been moved inside the Month Calendar component — Learn more.

  • The <PickersYear /> component has been moved inside the Year Calendar component — Learn more.

@flaviendelangle flaviendelangle marked this pull request as draft December 9, 2024 10:49
@mui-bot
Copy link

mui-bot commented Dec 9, 2024

@flaviendelangle flaviendelangle self-assigned this Dec 9, 2024
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! labels Dec 9, 2024
@flaviendelangle flaviendelangle changed the title [pickers] Remove PickersMonth and PickersYear from the theme and use display: grid [pickers] Remove PickersMonth and PickersYear from the theme and remove the div wrapping the buttons Dec 13, 2024
@flaviendelangle flaviendelangle changed the title [pickers] Remove PickersMonth and PickersYear from the theme and remove the div wrapping the buttons [pickers] Remove PickersMonth and PickersYear from the theme and remove the div wrapping each button Dec 13, 2024
@flaviendelangle flaviendelangle force-pushed the month-year-button branch 2 times, most recently from 7e25a8a to 5141c33 Compare December 13, 2024 09:45
@flaviendelangle flaviendelangle marked this pull request as ready for review December 13, 2024 10:08
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort here 🚀

Leaving a few styling-related comments 🙈

flaviendelangle and others added 2 commits December 18, 2024 12:37
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle flaviendelangle merged commit 1eaf1d8 into mui:master Dec 19, 2024
18 checks passed
@flaviendelangle flaviendelangle deleted the month-year-button branch December 19, 2024 09:55
lauri865 pushed a commit to lauri865/mui-x that referenced this pull request Dec 19, 2024
…remove the `div` wrapping each button (mui#15806)

Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
3 participants