Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[license] Use console.log for the error message on Codesandbox to avoid rendering error #15814

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Dec 9, 2024

Fixes #15765

It is a workaround until codesandbox/codesandbox-client#8673 is resolved

FYI @flaviendelangle
It should fix the Codesandbox of this example as well

@arminmeh arminmeh added package: x-license Specific to @mui/x-license. needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 9, 2024
@mui-bot
Copy link

mui-bot commented Dec 9, 2024

Deploy preview: https://deploy-preview-15814--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d7b000f

@arminmeh
Copy link
Contributor Author

arminmeh commented Dec 9, 2024

Workaround that helped with minimal reproduction code doesn't work here 😢

Row grouping example fails the same
TreeView as well

Data Grid Tree Data example fails with another error now

@cherniavskii
Copy link
Member

@arminmeh Adding @mui/x-data-grid and @mui/x-license to package.json explicitly seems to do the trick: https://codesandbox.io/p/sandbox/cocky-gwen-wf267p?file=%2Fpackage.json%3A8%2C13

@arminmeh
Copy link
Contributor Author

Adding @mui/x-data-grid and @mui/x-license to package.json explicitly seems to do the trick

Always forgetting about this "trick"

Same fixes the TreeView example

@arminmeh arminmeh merged commit bc1f0f4 into mui:master Dec 10, 2024
18 checks passed
@arminmeh arminmeh deleted the codesandbox-workaround branch December 10, 2024 06:39
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge package: x-license Specific to @mui/x-license. v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Examples in docs result in react error in code sandbox
3 participants