[pickers] Use the new ownerState object on the <PickersTextField /> component
#15863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15863--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
ownerState-input
branch
2 times, most recently
from
3618e05 to
306c64b
Compare
flaviendelangle
added
the
component: pickers
flaviendelangle
force-pushed
the
ownerState-input
branch
4 times, most recently
from
5779d6f to
fa018dc
Compare
flaviendelangle
changed the title
ownerState object on the PickersTextField component
72 tasks
flaviendelangle
commented
Dec 12, 2024
| @@ -46,7 +46,7 @@ export interface PickersArrowSwitcherOwnerState extends PickerOwnerState { | |||
| /** | |||
| * If `true`, this button should be hidden. | |||
| */ | |||
| hidden: boolean; | |||
| isButtonHidden: boolean; | |||
There was a problem hiding this comment.
I renamed that one to be consistent on the prefixing
flaviendelangle
force-pushed
the
ownerState-input
branch
from
fa018dc to
8bf4c02
Compare
flaviendelangle
force-pushed
the
ownerState-input
branch
from
53de30c to
b7d5af0
Compare
flaviendelangle
changed the title
ownerState object on the PickersTextField componentownerState object on the <PickersTextField /> component
michelengelen
approved these changes
Dec 16, 2024
packages/x-date-pickers/src/PickersTextField/PickersFilledInput/PickersFilledInput.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/PickersTextField/PickersFilledInput/PickersFilledInput.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/PickersTextField/PickersFilledInput/PickersFilledInput.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const round = (value: number) => Math.round(value * 1e5) / 1e5; | ||
|
|
||
| export const PickersInputBaseRoot = styled('div', { | ||
| name: 'MuiPickersInputBase', | ||
| slot: 'Root', | ||
| overridesResolver: (props, styles) => styles.root, | ||
| })<{ ownerState: OwnerStateType }>(({ theme }) => ({ | ||
| })<{ ownerState: PickersTextFieldOwnerState }>(({ theme }) => ({ |
There was a problem hiding this comment.
Just noticed this:
Do we intentionally use "TextField" here to show the meaning of the overall concept and "input" elsewhere to target the actual element?
There was a problem hiding this comment.
The Text Field is the component that contains the label, the error message etc... AND the input.
It's not a nomenclature I love tbh, but I tried to stay close from the core logic here to smoothen the migration 👍
LukasTy
reviewed
Dec 16, 2024
packages/x-date-pickers/src/PickersTextField/PickersFilledInput/PickersFilledInput.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/PickersTextField/PickersInput/PickersInput.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/PickersTextField/PickersInputBase/PickersInputBase.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/PickersTextField/PickersInputBase/PickersInputBase.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/PickersTextField/PickersTextField.tsx
Outdated
Show resolved
Hide resolved
lauri865
pushed a commit
to lauri865/mui-x
that referenced
this pull request
Dec 19, 2024
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14475
I forgot this one 😬