Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Update closeOnSelect and actionBar.actions default values #15944

Merged
merged 49 commits into from
Jan 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
0a15fe0
sets closeOnSelect to false by default on pickers containing time views
Aug 30, 2024
3814dd9
update tests
Aug 30, 2024
5bc04c8
update lifecycle docs
Aug 30, 2024
40aa049
add description for mobile pickers
Sep 3, 2024
b738d94
add description for DatePicker and DateRangePicker
Sep 3, 2024
4f1875b
add prop description for DateTime and DateTimeRange pickers
Sep 3, 2024
c5ab12a
add prop description for time picker
Sep 3, 2024
a11dff4
fix e2e tests
Sep 4, 2024
0aa7a31
remove unnecessary code wrap
arthurbalduini Oct 9, 2024
c37d64a
add closeOnSelect default values mention on onClose section
arthurbalduini Oct 16, 2024
85dfa43
fix grammar errors
arthurbalduini Oct 16, 2024
e33098a
update prop description on docs
arthurbalduini Oct 16, 2024
913d92b
use 'accept' and 'cancel' actions by default on all components
arthurbalduini Oct 23, 2024
f9ab3b5
use valueType on layout
arthurbalduini Oct 23, 2024
24bad2e
style adjustments
arthurbalduini Oct 23, 2024
19dee61
fix e2e test
arthurbalduini Oct 23, 2024
25416f5
adapt DesktopTimePicker tests
arthurbalduini Oct 29, 2024
10163cc
use actions on DesktopDateTimeRangePicker
arthurbalduini Oct 29, 2024
ac5ad51
adds 'accept' action click on tests
arthurbalduini Oct 30, 2024
0f9fe35
removes unnecessary duplicated comment
arthurbalduini Oct 30, 2024
b19348b
fix overextended interface
arthurbalduini Oct 30, 2024
1937341
define usePickerLayout as source of actions for actionBar
arthurbalduini Oct 30, 2024
c5160f5
remove unnecessary type ref
arthurbalduini Oct 30, 2024
31a12ac
remove unnecessary imports
arthurbalduini Oct 31, 2024
54c368c
revert layout changes
arthurbalduini Oct 31, 2024
eb20b49
revert ValueType usage
arthurbalduini Nov 5, 2024
d098ecd
PR reviews
arthurbalduini Nov 12, 2024
df06377
lukas review
arthurbalduini Nov 12, 2024
e7b6345
apply lukas suggestion on action logic
arthurbalduini Nov 12, 2024
db08ac4
remove unnecessary overrides
arthurbalduini Nov 12, 2024
5039c0d
remove spacing
arthurbalduini Nov 12, 2024
a82f515
revert MultiSectionDigitalClock layout changes
arthurbalduini Nov 12, 2024
451e218
Update lifecycle
LukasTy Dec 19, 2024
0dba2a9
Add a migration section
LukasTy Dec 19, 2024
cfe82d2
Merge branch 'master' into refactor-closeOnSelect-behavior-2
LukasTy Dec 20, 2024
57aa161
fix eslint
LukasTy Dec 20, 2024
e07a0e3
Remove no longer relevant change
LukasTy Dec 20, 2024
38b3623
Simplify `closeOnSelect` default value setting
LukasTy Dec 20, 2024
23e6a45
Add explicit `ownerState` type
LukasTy Dec 20, 2024
02f53e3
Update the test approach
LukasTy Dec 20, 2024
45e9cff
Change import to avoid any changes
LukasTy Dec 20, 2024
1280ffb
Apply suggestions from code review
LukasTy Dec 20, 2024
c876b9b
Link to doc example
LukasTy Dec 30, 2024
208f289
Avoid the unclear notion of `complex views`
LukasTy Dec 30, 2024
127d4c7
Fix JSDoc comment
LukasTy Dec 30, 2024
4298c51
Merge branch 'master' into refactor-closeOnSelect-behavior-2
LukasTy Dec 30, 2024
ee93a44
Code review: Flavien
LukasTy Jan 3, 2025
88f2de9
Merge branch 'master' into refactor-closeOnSelect-behavior-2
LukasTy Jan 3, 2025
578640c
Make default `actions` stable to avoid breaking possible memoization
LukasTy Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix overextended interface
arthurbalduini authored and LukasTy committed Dec 19, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit b19348bf0c218a383a1344cf0de044f30fbcbae1
Original file line number Diff line number Diff line change
@@ -54,8 +54,10 @@
"formatDensity": {
"description": "Density of the format when rendered in the input. Setting <code>formatDensity</code> to <code>&quot;spacious&quot;</code> will add a space before and after each <code>/</code>, <code>-</code> and <code>.</code> character."
},
"inputRef": { "description": "Pass a ref to the <code>input</code> element." },
"label": { "description": "The label content." },
"inputRef": {
"description": "Pass a ref to the <code>input</code> element. Ignored if the field has several inputs."
},
"label": { "description": "The label content. Ignored if the field has several inputs." },
"loading": {
"description": "If <code>true</code>, calls <code>renderLoading</code> instead of rendering the day calendar. Can be used to preload information and show it in calendar."
},
@@ -65,7 +67,7 @@
"maxDate": { "description": "Maximal selectable date." },
"minDate": { "description": "Minimal selectable date." },
"name": {
"description": "Name attribute used by the <code>input</code> element in the Field."
"description": "Name attribute used by the <code>input</code> element in the Field. Ignored if the field has several inputs."
},
"onAccept": {
"description": "Callback fired when the value is accepted.",
Original file line number Diff line number Diff line change
@@ -58,8 +58,10 @@
"formatDensity": {
"description": "Density of the format when rendered in the input. Setting <code>formatDensity</code> to <code>&quot;spacious&quot;</code> will add a space before and after each <code>/</code>, <code>-</code> and <code>.</code> character."
},
"inputRef": { "description": "Pass a ref to the <code>input</code> element." },
"label": { "description": "The label content." },
"inputRef": {
"description": "Pass a ref to the <code>input</code> element. Ignored if the field has several inputs."
},
"label": { "description": "The label content. Ignored if the field has several inputs." },
"loading": {
"description": "If <code>true</code>, calls <code>renderLoading</code> instead of rendering the day calendar. Can be used to preload information and show it in calendar."
},
@@ -82,7 +84,7 @@
},
"minutesStep": { "description": "Step over minutes." },
"name": {
"description": "Name attribute used by the <code>input</code> element in the Field."
"description": "Name attribute used by the <code>input</code> element in the Field. Ignored if the field has several inputs."
},
"onAccept": {
"description": "Callback fired when the value is accepted.",
Original file line number Diff line number Diff line change
@@ -194,10 +194,12 @@ MobileDateRangePicker.propTypes = {
formatDensity: PropTypes.oneOf(['dense', 'spacious']),
/**
* Pass a ref to the `input` element.
* Ignored if the field has several inputs.
*/
inputRef: refType,
/**
* The label content.
* Ignored if the field has several inputs.
*/
label: PropTypes.node,
/**
@@ -223,6 +225,7 @@ MobileDateRangePicker.propTypes = {
minDate: PropTypes.object,
/**
* Name attribute used by the `input` element in the Field.
* Ignored if the field has several inputs.
*/
name: PropTypes.string,
/**
Original file line number Diff line number Diff line change
@@ -321,10 +321,12 @@ MobileDateTimeRangePicker.propTypes = {
formatDensity: PropTypes.oneOf(['dense', 'spacious']),
/**
* Pass a ref to the `input` element.
* Ignored if the field has several inputs.
*/
inputRef: refType,
/**
* The label content.
* Ignored if the field has several inputs.
*/
label: PropTypes.node,
/**
@@ -373,6 +375,7 @@ MobileDateTimeRangePicker.propTypes = {
minutesStep: PropTypes.number,
/**
* Name attribute used by the `input` element in the Field.
* Ignored if the field has several inputs.
*/
name: PropTypes.string,
/**