[CHANGELOG] Add missing entries #16030
Open
+332
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-16030--material-ui-x.netlify.app/ |
oliviertassinari
changed the title
LukasTy
approved these changes
Dec 30, 2024
| @@ -339,7 +339,7 @@ async function main(argv) { | |||
| }; | |||
|
|
|||
| const changelog = ` | |||
| ## __VERSION__ | |||
| ## v__VERSION__ | |||
There was a problem hiding this comment.
If others are fine with aligning on keeping the v prefix, I'm good with this. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on #16031 and need to know in which version #15521 was released to recreate a reproduction. I found no match for
#15521in the codebase, from there I knew something was broken.As it turned out, this was released in v8.0.0-alpha.2. Proof: nor https://github.com/mui/mui-x/releases/tag/v8.0.0-alpha.2 or #15656 has it.
As for why it happened, I guess it's because of this, see the timeline:
Edit: Ah actually, looking at why it happened made me wonder if we didn't miss other entries in the changelog. And yes, bingo v8.0.0-alpha.1...v8.0.0-alpha.2 PR updated.
I use the CHANGELOG.md very often to pinpoint where regressions started, I would imagine developers use the CHANGELOG.md to figure out in which version changes were released. So I think we need this to be accurate.
We could solve this at the root with: mui/mui-public#259.
Edit: Ah the h2 version header is wrong, inconsistent with Material UI and Base UI. I have fixed it and updated the existing ones for the past, and the changelog generation script for the future.
Edit: While I was at it, I brought the least changelog from the v7.x branch.
Edit: Ah #15655 as the same issue with missing entries v7.22.3...v7.23.0, I have brought them back here.