Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Fix loading issue + add skeleton overlay #16282

Merged
merged 23 commits into from
Feb 11, 2025
Merged

[DataGridPremium] Fix loading issue + add skeleton overlay #16282

merged 23 commits into from
Feb 11, 2025

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Jan 21, 2025 •
edited
Loading

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature feature: Server integration Better integration with backends, e.g. data source labels Jan 21, 2025
@mui-bot
Copy link

mui-bot commented Jan 21, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16282--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1b494f3

@MBilalShafi MBilalShafi mentioned this pull request Jan 21, 2025
Closed
@MBilalShafi MBilalShafi marked this pull request as ready for review January 21, 2025 10:54
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2025
@MBilalShafi MBilalShafi changed the title [DataGridPremium] Fix initial loading state not being displayed [DataGridPremium] Fix loading issue + add skeleton overlay Jan 29, 2025
arminmeh
arminmeh approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@arminmeh arminmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

KenanYusuf
KenanYusuf reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a couple of minor things but it looks great 👍

@KenanYusuf KenanYusuf self-requested a review February 3, 2025 11:21
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 5, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 6, 2025
@MBilalShafi MBilalShafi merged commit 26e7d21 into mui:master Feb 11, 2025
18 checks passed
@MBilalShafi MBilalShafi deleted the fix-loading-issue branch February 11, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanYusuf KenanYusuf KenanYusuf approved these changes

@arminmeh arminmeh Awaiting requested review from arminmeh

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature feature: Server integration Better integration with backends, e.g. data source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] loading does not work with dataSource in DataGridPremium
4 participants
@MBilalShafi @mui-bot @arminmeh @KenanYusuf