[DataGrid] Improve `headerClassName` type #1778

DanailH · 2021-05-28T10:00:36Z

[DataGrid] Improve headerClassName type

-cellClassName?: string | string[] | (params: GridCellParams) => string;
+cellClassName?: string | (params: GridCellParams) => string;

-headerClassName?: string | string[];
+headerClassName?: string | (params: GridColumnHeaderParams) => string;

Fixes #274

packages/grid/data-grid/src/tests/columnHeaders.DataGrid.spec.tsx

packages/grid/_modules_/grid/models/gridColumnHeaderClass.ts

packages/grid/_modules_/grid/models/gridCellClass.ts

packages/grid/_modules_/grid/components/columnHeaders/GridColumnHeaderItem.tsx

DanailH added 4 commits May 28, 2021 12:47

Changed headerClassName type

bf967f9

Revert changes

5e85bfc

Remove comment

6c230d5

Update docs

04bc6de

DanailH added breaking change new feature New feature or request labels May 28, 2021

DanailH requested review from dtassone, oliviertassinari and m4theushw May 28, 2021 10:00

DanailH self-assigned this May 28, 2021

oliviertassinari reviewed May 28, 2021

View reviewed changes

oliviertassinari changed the title ~~[DataGrid] Change headerClassName type~~ [DataGrid] Improve headerClassName type May 28, 2021

m4theushw reviewed May 28, 2021

View reviewed changes

packages/grid/_modules_/grid/components/columnHeaders/GridColumnHeaderItem.tsx Outdated Show resolved Hide resolved

DanailH added 2 commits May 31, 2021 11:06

Make the tests correct

7ffdb9a

Remove unneeded clsx usage

409acc3

DanailH requested a review from m4theushw May 31, 2021 08:13

dtassone approved these changes May 31, 2021

View reviewed changes

m4theushw approved these changes May 31, 2021

View reviewed changes

DanailH merged commit b7e84aa into mui:master May 31, 2021

Provide feedback