Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Allow passing styles and Popper props to GridPanel #1994

Merged
merged 10 commits into from
Jul 12, 2021
Merged

[DataGrid] Allow passing styles and Popper props to GridPanel #1994

merged 10 commits into from
Jul 12, 2021

Conversation

sebastianfrey
Copy link
Contributor

Closes #1808.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jun 29, 2021
@oliviertassinari
Copy link
Member

A good opportunity to add a describeConformance test for this component.

@sebastianfrey
Copy link
Contributor Author

Where should I place the test? Inside packages/grid/data-grid/src/tests/components.DataGrid.test.tsx?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 29, 2021

Where should I place the test?

Where it optimizes for removing code: /packages/grid/_modules_/grid/components/panel/GridPanel.test.tsx.

@sebastianfrey sebastianfrey changed the title [DataGrid] Allow passing styles and Popper props GridPanel [DataGrid] Allow passing styles and Popper props to GridPanel Jun 29, 2021
@oliviertassinari oliviertassinari removed their assignment Jul 5, 2021
@oliviertassinari oliviertassinari requested a review from a team July 5, 2021 21:39
@oliviertassinari
Copy link
Member

I have polished the PR. It should be OK now. In the future, we will likely need to add a components and componentsProps props to this component.

@sebastianfrey
Copy link
Contributor Author

Thanks for the update. Since I had to do some priority tasks in my day to day job, I have not yet got around to write some tests.

@oliviertassinari
Copy link
Member

I have already added a TypeScript test case. I'm adding a describe conformance, we have never used this before, time to introduce it.

@sebastianfrey
Copy link
Contributor Author

@oliviertassinari Ah, sry for pushing my test.. I did not read your answer in time.

@oliviertassinari oliviertassinari requested a review from a team July 7, 2021 14:32
@m4theushw m4theushw merged commit b88f9ef into mui:master Jul 12, 2021
@flaviendelangle
Copy link
Member

https://app.circleci.com/pipelines/github/mui-org/material-ui-x/6058/workflows/52b8b247-8918-418a-831f-3440e0e27acb/jobs/31886

@oliviertassinari getClasses has been removed on this commit mui/material-ui@2569eb9#diff-f075d81b14df1f31fb0699c4516fe3d78490351867feeb4fb869d5dbe8c6128e

On the core, they are directly importing the classes for the component file (like we want to do in #1950)
But in the meantime do we have a better solution than copy/paste the getClasses that used to be in the core in our repo ?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 13, 2021

@flaviendelangle I see, we got a conflict between #1994 and #2114, that broke master. getClasses is a trivial helper, we can add it back with a "TODO v5 remove" or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Preferences Panel should not exceed Grid height
5 participants