-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Allow passing styles and Popper props to GridPanel #1994
Conversation
A good opportunity to add a |
Where should I place the test? Inside |
Where it optimizes for removing code: |
I have polished the PR. It should be OK now. In the future, we will likely need to add a |
Thanks for the update. Since I had to do some priority tasks in my day to day job, I have not yet got around to write some tests. |
I have already added a TypeScript test case. I'm adding a describe conformance, we have never used this before, time to introduce it. |
@oliviertassinari Ah, sry for pushing my test.. I did not read your answer in time. |
@oliviertassinari On the core, they are directly importing the classes for the component file (like we want to do in #1950) |
@flaviendelangle I see, we got a conflict between #1994 and #2114, that broke master. |
Closes #1808.