[DataGrid] Warn when pageSize is not present in rowsPerPageOptions

[flaviendelangle]

One chunk of #1907

[flaviendelangle]

The snapshots changes are expected, we don't pass rawPerPageOptions as props so the default one are used (DEFAULT_GRID_OPTIONS.rowsPerPageOptions)

Before this PR, the default one did not include the pageSize in these tests so we did not show the select.
Now we automatically add the pageSize and show the select.

[flaviendelangle]

@oliviertassinari , I updated the behavior as discussed yesterday 👍

[flaviendelangle]

Their is an error on a test because the effect runs with the default pageSize and then with the value passed by the user.
It should be fixed by the clean controlled state. It put this PR on hold until it's done 👍

[oliviertassinari]

👍 for the current direction

[oliviertassinari]

@flaviendelangle I have rebased and updated the tests to pass. A codesandbox with the new DX: https://codesandbox.io/s/material-demo-forked-pjlyc?file=/demo.tsx. However, having to include 100 in the list, that's not flying 😁. The simplest might be to add a hack for 100 and to leave a TODO.

Updating the options in an effect? It's borderline. I think that it would only work under two conditions: 1. We initiate the state with the right initial options (KO currently) 2. We make the child of the state provider a memo, to always stop the React rendering so that children only render once per option updates (KO currently).

Otherwise, we can use React, create a dedicated context for the options (top-level props).

[m4theushw]

In #1720 a new GridRootPropsContext context was added with the root props. You can use it instead of querying the state. We get for free the advantage of not having to add 100 to the list. You just have to solve the dependency cycle, maybe add the prop you need in the parent element and pass it to the pagination component.

[flaviendelangle]

I'll finish this one once the controlled pagination is merged
And I agree, looking at the input props should help

[flaviendelangle]

https://app.circleci.com/pipelines/github/mui-org/material-ui-x/6357/workflows/3eb1a423-62eb-40b7-b3ff-5cf21a9beef9/jobs/33830

@oliviertassinari if I set a global variable to only warn once, it's not reset between two tests so 2 of the 3 tests don't have the warning.
I'm using a ref to bypass this issue.

[flaviendelangle]

Same reason as https://github.com/mui-org/material-ui-x/pull/2213/files#r676538144
It's to avoid circle import

[oliviertassinari]

@flaviendelangle

You have lost two of my commits 8ebd389 f09aa4d. Is it on purpose? Anyway, it's not really important, if you can check that we don't miss anything from them, it would be 👌

[oliviertassinari]

Looks good

[flaviendelangle]

@oliviertassinari what was the goal of adding the 100 in rowsPerPageOptions ?

[oliviertassinari]

what was the goal of adding the 100 in rowsPerPageOptions ?

@flaviendelangle To dodge the initial value issue. You fixed this using the root props context.

[oliviertassinari]

It looks clean