-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[docs] Replace deprecated LoadingButton with Button component
#20208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Replace deprecated LoadingButton with Button component
#20208
Conversation
Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>
|
Deploy preview: https://deploy-preview-20208--material-ui-x.netlify.app/ Bundle size report
|
|
@copilot run prettier |
Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
| return ( | ||
| <div style={{ width: '100%' }}> | ||
| <div style={{ marginBottom: 8 }}> | ||
| <LoadingButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mui/xgrid Or are these still here for a reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so.
This is fine to be merged.
LoadingButton with Button component
…i#20208) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>
Convert all LoadingButton instances to Button component as per Material UI deprecation warning
Summary
All instances of LoadingButton have been successfully replaced with the Button component from @mui/material. The
loadingandloadingPositionprops have been retained as they are now natively supported by the Button component in Material UI v6+. The deprecation warning filter has been removed from the regression test file. Removed the unusedisMaterialUIv7variable that was only used in the removed warning filter. Code has been formatted with prettier and passes ESLint checks.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.