Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 5, 2025

Convert all LoadingButton instances to Button component as per Material UI deprecation warning

  • Replace LoadingButton with Button in BulkEditing.tsx
  • Replace LoadingButton with Button in BulkEditing.js
  • Replace LoadingButton with Button in BulkEditingPremiumNoSnap.tsx
  • Replace LoadingButton with Button in BulkEditingPremiumNoSnap.js
  • Update test file to remove LoadingButton warning filter (index.test.ts)
  • Run prettier to format code
  • Remove unused isMaterialUIv7 variable
  • Verify linting passes

Summary

All instances of LoadingButton have been successfully replaced with the Button component from @mui/material. The loading and loadingPosition props have been retained as they are now natively supported by the Button component in Material UI v6+. The deprecation warning filter has been removed from the regression test file. Removed the unused isMaterialUIv7 variable that was only used in the removed warning filter. Code has been formatted with prettier and passes ESLint checks.

Original prompt

Noticed a log

2:26:31 PM: MUI: The LoadingButton component functionality is now part of the Button component from Material UI.
2:26:31 PM: You should use `import Button from '@mui/material/Button'`
2:26:31 PM: or `import { Button } from '@mui/material'`

when running pnpm docs:build
convert all instances of LoadingBUtton


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Nov 5, 2025

Deploy preview: https://deploy-preview-20208--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 99e3253

@Janpot
Copy link
Member

Janpot commented Nov 5, 2025

@copilot run prettier

Copilot AI changed the title [WIP] Refactor LoadingButton to use Button component Replace deprecated LoadingButton with Button component Nov 5, 2025
Copilot AI requested a review from Janpot November 5, 2025 13:37
Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 5, 2025

@copilot run prettier

Done. Prettier formatted the if statement in test/regressions/index.test.ts to be on a single line. (b622116)

@Janpot Janpot added docs Improvements or additions to the documentation. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Nov 5, 2025
@Janpot

This comment was marked as resolved.

Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>

This comment was marked as outdated.

return (
<div style={{ width: '100%' }}>
<div style={{ marginBottom: 8 }}>
<LoadingButton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui/xgrid Or are these still here for a reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so.
This is fine to be merged.

@Janpot Janpot marked this pull request as ready for review November 17, 2025 09:06
@zannager zannager added the scope: data grid Changes related to the data grid. label Nov 17, 2025
@cherniavskii cherniavskii changed the title Replace deprecated LoadingButton with Button component [docs] Replace deprecated LoadingButton with Button component Nov 19, 2025
@cherniavskii cherniavskii merged commit 7d1fa69 into master Nov 19, 2025
21 checks passed
@cherniavskii cherniavskii deleted the copilot/replace-loading-button-component branch November 19, 2025 19:25
mapache-salvaje pushed a commit to mapache-salvaje/mui-x that referenced this pull request Dec 29, 2025
…i#20208)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Janpot <2109932+Janpot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants