Skip to content

Conversation

@cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Nov 14, 2025

Our exceljs fork package is published manually from a different repo.
As opposed to this repo, which has trusted publishing configured.
Locking the version adds another security step, since we'll have to approve and merge dependabot PR to bump the version before it can be used.

Related discussion: https://www.notion.so/mui-org/code-infra-Chapter-Meeting-2025-11-14-29dcbfe7b66080d29b90e73deda9e8fd?source=copy_link#29dcbfe7b6608099867be907ff520c3a

@cherniavskii cherniavskii added scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Nov 14, 2025
@mui-bot
Copy link

mui-bot commented Nov 14, 2025

Deploy preview: https://deploy-preview-20329--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 27e6819

@cherniavskii cherniavskii marked this pull request as ready for review November 17, 2025 14:05
@cherniavskii cherniavskii requested a review from a team November 17, 2025 14:09
@cherniavskii cherniavskii added the plan: Premium Impact at least one Premium user. label Nov 17, 2025
@cherniavskii cherniavskii merged commit ee5f69d into mui:master Nov 17, 2025
23 checks passed
@cherniavskii cherniavskii deleted the lock-exceljs-version branch November 17, 2025 15:19
mapache-salvaje pushed a commit to mapache-salvaje/mui-x that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan: Premium Impact at least one Premium user. scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants