[charts] Prevent pointer out from removing controlled highlight #20385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
requested review from
JCQuintas and
bernardobelchior
as code owners
alexfauquette
added
type: bug
|
Deploy preview: https://deploy-preview-20385--material-ui-x.netlify.app/ Bundle size report
|
JCQuintas
reviewed
Nov 19, 2025
| ...prevHighlight, | ||
| item: null, | ||
| lastUpdate: 'pointer', | ||
| isControlled: false, |
Member
There was a problem hiding this comment.
Why do we change this to false? 🤔
Member
Author
There was a problem hiding this comment.
We don't really modify it. If it was true an early return would be trigger
Member
Author
There was a problem hiding this comment.
In the version you've seen few minutes ago, there were a ...prevHighlight I've removed but forgot to push
alexfauquette
commented
Nov 19, 2025
|
|
||
| store.set('highlight', { item: null, lastUpdate: 'pointer' }); | ||
| store.set('highlight', { | ||
| ...prevHighlight, |
Member
Author
There was a problem hiding this comment.
Suggested change
| ...prevHighlight, |
alexfauquette
force-pushed
the
fix-20381
branch
from
b680df2 to
ca3763e
Compare
JCQuintas
approved these changes
Nov 19, 2025
Member
JCQuintas
left a comment
JCQuintas
left a comment
There was a problem hiding this comment.
Should we have a test to prevent regression?
packages/x-charts/src/internals/plugins/featurePlugins/useChartHighlight/useChartHighlight.ts
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #20385 will not alter performanceComparing Summary
Footnotes |
mapache-salvaje
pushed a commit
to mapache-salvaje/mui-x
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20381
The issue come from the fact pointer event were still able to override the value even if controlled.