[tree view] Update the typing of updateItemChildren() to accept null
#20483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
noraleonte
commented
Nov 28, 2025
noraleonte
commented
- I have followed (at least) the PR section of the contributing guide.
noraleonte
added
type: enhancement
|
Deploy preview: https://deploy-preview-20483--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the updateItemChildren API method in the Tree View component to accept null as a parameter, enabling developers to refresh the entire tree's root children. This is a useful feature for scenarios where the complete tree data needs to be reloaded rather than just a specific item's children.
Key Changes:
- Updated the
updateItemChildrentype signature to acceptTreeViewItemId | nullinstead of justTreeViewItemId - Added comprehensive test coverage for both null and non-null parameter cases
- Updated API documentation to clarify the null parameter behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/x-tree-view/src/internals/plugins/useTreeViewLazyLoading/useTreeViewLazyLoading.types.ts |
Updated type signature and JSDoc for updateItemChildren to accept null parameter |
packages/x-tree-view-pro/src/internals/plugins/useTreeViewLazyLoading/useTreeViewLazyLoading.test.tsx |
Added two test cases covering null and itemId parameters for updateItemChildren method |
docs/data/tree-view/rich-tree-view/lazy-loading/lazy-loading.md |
Added inline comment explaining null parameter usage in API documentation |
...ges/x-tree-view/src/internals/plugins/useTreeViewLazyLoading/useTreeViewLazyLoading.types.ts
Outdated
Show resolved
Hide resolved
…ing/useTreeViewLazyLoading.types.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
flaviendelangle
changed the title
updateItemChildren accept nullupdateItemChildren() to accept null
flaviendelangle
approved these changes
Dec 4, 2025
A-s-h-o-k
pushed a commit
to A-s-h-o-k/mui-x
that referenced
this pull request
Dec 14, 2025
mui#20483) Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mapache-salvaje
pushed a commit
to mapache-salvaje/mui-x
that referenced
this pull request
Dec 29, 2025
mui#20483) Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.