Skip to content

[data grid] Sync component props with theme defaults #20590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michelengelen merged 2 commits into from
Dec 8, 2025
Merged

[data grid] Sync component props with theme defaults #20590

michelengelen merged 2 commits into from
Dec 8, 2025

Conversation

@michelengelen
Copy link
Member

@michelengelen michelengelen commented Dec 8, 2025

This PR makes the grid’s material wrappers honor theme defaults, improving consistency with app-wide MUI configuration.

  • BaseSelect now reads MuiTextField.defaultProps via useTheme and applies computed variant and size to FormControl, InputLabel, and Select.
    • Removed hardcoded variant="outlined" and the notched prop.
  • BaseTextField now derives variant and size from MuiTextField.defaultProps when not explicitly provided.

Fixes #20335

@michelengelen
Sync component props with theme defaults for size and variant in mate…
7d7a9c5 
…rial components

Signed-off-by: michel <jsnerdic@gmail.com>
@michelengelen michelengelen self-assigned this Dec 8, 2025
@michelengelen michelengelen added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. labels Dec 8, 2025
@michelengelen michelengelen removed the request for review from romgrk December 8, 2025 08:50
@mui-bot
Copy link

mui-bot commented Dec 8, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20590--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+157B(+0.04%) 🔺+61B(+0.05%)
@mui/x-data-grid-pro 🔺+157B(+0.03%) 🔺+69B(+0.05%)
@mui/x-data-grid-premium 🔺+157B(+0.02%) 🔺+53B(+0.03%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 02e38b8

@michelengelen
prettier
02e38b8 
Signed-off-by: michel <jsnerdic@gmail.com>
@michelengelen michelengelen enabled auto-merge (squash) December 8, 2025 14:06
@michelengelen michelengelen merged commit 66ba6f7 into mui:master Dec 8, 2025
21 checks passed
@michelengelen michelengelen deleted the bugfix/20335 branch December 8, 2025 14:36
A-s-h-o-k pushed a commit to A-s-h-o-k/mui-x that referenced this pull request Dec 14, 2025
@michelengelen @A-s-h-o-k
[data grid] Sync component props with theme defaults (mui#20590)
9338b55 
Signed-off-by: michel <jsnerdic@gmail.com>
mapache-salvaje pushed a commit to mapache-salvaje/mui-x that referenced this pull request Dec 29, 2025
@michelengelen @mapache-salvaje
[data grid] Sync component props with theme defaults (mui#20590)
8d7cd8c 
Signed-off-by: michel <jsnerdic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arminmeh arminmeh arminmeh approved these changes

@mj12albert mj12albert Awaiting requested review from mj12albert

Assignees

@michelengelen michelengelen

Labels

scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] Filter input value doesn't respect the TextField theme props

3 participants

@michelengelen @mui-bot @arminmeh