Skip to content

[DataGridPremium] Handle pivoting column name generation for empty strings #20608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arminmeh merged 2 commits into from
Dec 10, 2025
Merged

[DataGridPremium] Handle pivoting column name generation for empty strings #20608

arminmeh merged 2 commits into from
Dec 10, 2025

Conversation

@arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Dec 9, 2025

Fixes #20552

@arminmeh arminmeh requested a review from cherniavskii December 9, 2025 21:08
@arminmeh arminmeh added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. plan: Premium Impact at least one Premium user. feature: Pivoting Related to the data grid pivoting feature labels Dec 9, 2025
@mui-bot
Copy link

mui-bot commented Dec 9, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20608--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 🔺+24B(0.00%) 🔺+10B(+0.01%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 55fd3fc

cherniavskii
cherniavskii approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@arminmeh arminmeh merged commit 2fec5b6 into mui:master Dec 10, 2025
21 checks passed
@arminmeh arminmeh deleted the pivoting-column-empty-string branch December 10, 2025 14:24
A-s-h-o-k pushed a commit to A-s-h-o-k/mui-x that referenced this pull request Dec 14, 2025
@arminmeh @A-s-h-o-k
[DataGridPremium] Handle pivoting column name generation for empty st…
485c7eb 
…rings (mui#20608)
mapache-salvaje pushed a commit to mapache-salvaje/mui-x that referenced this pull request Dec 29, 2025
@arminmeh @mapache-salvaje
[DataGridPremium] Handle pivoting column name generation for empty st…
5f79462 
…rings (mui#20608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees

No one assigned

Labels

feature: Pivoting Related to the data grid pivoting feature plan: Premium Impact at least one Premium user. scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DataGrid] pivoting not working with columns that can have empty strings as values

3 participants

@arminmeh @mui-bot @cherniavskii