[core] Remove use of getState #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
|
@m2mathew do you remember exactly what was the purpose of |
|
We had a getState(subpart: string) API at some point 🤷♂️, happy with whatever direction we take here. |
m4theushw
reviewed
Aug 10, 2021
| @@ -8,8 +8,7 @@ export interface GridStateApi { | |||
| state: GridState; | |||
| /** | |||
| * Returns the state of the grid. | |||
| * @param {string} stateId The part of the state to be returned. | |||
| * @returns {any} The state of the grid. | |||
| * @returns {GridState} The state of the grid. | |||
There was a problem hiding this comment.
Should we not document it for now?
Suggested change
| * @returns {GridState} The state of the grid. | |
| * @returns {GridState} The state of the grid. | |
| * @ignore - do not document. |
There was a problem hiding this comment.
If we stop using it internally, we can just remove it.
There was a problem hiding this comment.
@flaviendelangle Removing the method would be a breaking change. We can move more iteratively.
|
I've resolved the conflicts, removed a few remaining |
mbrookes
changed the title
|
@m4theushw Thanks |
oliviertassinari
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up on #2208 (comment). I don't get why we even have such
getStatemethod. For #820, I think that we could restructure the state, and maybe havegetStatereturns a subset of the state that is public.