-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Use same infra from v5 #2441
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I was trying to make the docs work, compile. So this is that effort |
This comment has been minimized.
This comment has been minimized.
Finally the docs is using the same infra from the core v5. There're still some small things that I'll fix in a follow-up. This PR is already giant.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great first iteration. This one required to dive deep into the structure of the repositories, well done
Also, it's awesome that we finally reconcile the docs of MUI X with MUI Core 🎉. A couple of feedback to the core:
https://deploy-preview-2441--material-ui-x.netlify.app/components/data-grid/demo/
|
Let me quickly separate the answer into two topics:
Anyway, I think we should probably create a second Docs polishments PR for addressing these two (visual solution for nested levels on the sidebar and content regrouping) and other small details left open from the first PR. We can move these discussions further there. It would be nice to do that before v5 stable. How do you feel about it? @mnajdova @siriwatknp |
Based on this commit 50a16a1
Preview: https://deploy-preview-2441--material-ui-x.netlify.app/components/data-grid/