[core] Run at most one setGridState and one applyFilters when updating the filterModel due to column changes #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the filterModel due to column changes
flaviendelangle
added
performance
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, for N column with a filter removed, we ran (N+1)
applyFiltersand NsetGridState.For instance, if we changed the columns but did not impact any column with a filterItem, we re-applied the filter anyway.
And if we removed 2 columns that had a filter item, we ran the filters 3 times and did 2 `setGridState).
And the best scenario for the end, if you removed all the columns that had a filter item, it was N+2
applyFilters.So if you had 2 filter item, you removed both columns, you ended up with 4 application of the filters.