[DataGrid] Keyboard navigation broken on page > 0 #3074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #2994, was never released, I will merge it before the next release if no review 👍
The variable wording was approximate and I did not test enough.
rowCount
was refering to the index of the last element of the page + 1A few examples:
rows.length: 100, page: 0, pageSize: 10
=>rowCount: 10
rows.length: 100, page: 1, pageSize: 10
=>rowCount: 20
rows.length: 14, page: 1, pageSize: 10
=>rowCount: 14
I will probably clean those methods later to add explicit comments on each instruction.
Because
// we go to the current row, first col, or last col!
is not very explicit to me.