Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve testing of the keyboard navigation #3187

Merged
merged 3 commits into from
Nov 18, 2021
Merged

[core] Improve testing of the keyboard navigation #3187

merged 3 commits into from
Nov 18, 2021

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 15, 2021 •
edited
Loading

Before opening my PR about the keyboard navigation improvements, I tried to improve the tests.

  • getActiveColumnHeader should be 0-based for consistency with the rest
  • All the keyboard navigation keys should be correctly tested with filters, on page > 0 and when reaching the limits (ArrowDown on last row, ArrowUp on 1st row, ArrowLeft on 1st col, etc...)

If you want to take a look at the rework: #3093

@flaviendelangle flaviendelangle self-assigned this Nov 15, 2021
@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes test labels Nov 15, 2021
alexfauquette
alexfauquette approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more unified than before

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 16, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 16, 2021
@flaviendelangle flaviendelangle merged commit a4a884a into mui:next Nov 18, 2021
@flaviendelangle flaviendelangle deleted the keyboard-tests branch November 18, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaviendelangle @alexfauquette