Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve tests for Tree Data #3366

Merged
merged 5 commits into from
Dec 9, 2021
Merged

[core] Improve tests for Tree Data #3366

merged 5 commits into from
Dec 9, 2021

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Dec 6, 2021 •
edited
Loading

Extracted from #3277

  • Use defaultExpansionDepth={-1} when testing the order of the rows instead of manually expanding a single group
  • Uncomment an expect that I forgot to uncomment on the main PR
  • Add a test on toggling disableChildrenSorting and disableChildrenFiltering

As it is only test additions, I can auto-merge in a few days if you want to focus on other reviews 👍

@flaviendelangle flaviendelangle self-assigned this Dec 6, 2021
@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes test labels Dec 6, 2021
@flaviendelangle flaviendelangle mentioned this pull request Dec 6, 2021
Merged
@flaviendelangle flaviendelangle merged commit 986900e into mui:master Dec 9, 2021
@flaviendelangle flaviendelangle deleted the test-tree-data branch December 9, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@flaviendelangle flaviendelangle

Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flaviendelangle