[DataGridPro] Add new option hideDescendantCount to Tree Data #3368
Conversation
flaviendelangle
force-pushed
the
hide-descendant-count
branch
from
a27978c to
76df4bb
Compare
| @@ -1,5 +1,4 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/types/global" /> | |||
There was a problem hiding this comment.
Do you know what caused this modification?
There was a problem hiding this comment.
Probably this one
I checked the NextJS example and they have this line
There was a problem hiding this comment.
https://github.com/vercel/next.js/pull/28316/files
I think I found the PR
|
|
||
| const commonProperties: Omit<GridColDef, 'field' | 'editable'> = { | ||
| ...GRID_TREE_DATA_GROUP_COL_DEF, | ||
| renderCell: (params) => ( |
There was a problem hiding this comment.
Why do you not hideDescendantCount to the colDef and use this parameter in the <GridTreeDataGroupingCell /> component like colDef.valueOptions for <GridEditSingleSelectCell />?
There was a problem hiding this comment.
I wanted to avoid adding properties on the colDef that are only useful for the grouping column.
But if the team feels like it's better to pass it to the colDef then I just have to move hideDescendantCount from GridGroupingColDefOverride to GridColDef and access it through the colDefprop in the cell component.
There was a problem hiding this comment.
Make sense, but when defining groupingColDef developers will probably expect their props to be in the colDef
There was a problem hiding this comment.
For column grouping I have other properties only usefull for the grouping column.
Putting everything on the colDef is not great I think.
|
I agree with you on the doc. The component API should be enough |
zannager
added
component: data grid
Extracted from #3277
Will be properly documented and tested in the docs of the grouping columns, I don't think it's worth creating an example for the Tree Data.