Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix TypeScript definitions published on npm #343

Closed
wants to merge 3 commits into from
Closed

[DataGrid] Fix TypeScript definitions published on npm #343

wants to merge 3 commits into from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 22, 2020 •
edited
Loading

Build on top of #341, exploration for #339.

@oliviertassinari oliviertassinari force-pushed the yolo branch 2 times, most recently from 38e5d71 to 364f540 Compare September 22, 2020 22:53
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 22, 2020 •
edited
Loading

The issue with @material-ui/data-grid is solved. However:

  • @material-ui/x-grid still fails because @material-ui/x-license isn't available on npm.
  • Are you sure about rollup-plugin-dts? It seems to make debugging harder (when there is a fail).
  • We can still remove a bunch of code related to @material-ui/x-grid-modules (e.g. its rollup config).

@mbrookes
Copy link
Member

@material-ui/x-license isn't available on npm

https://www.npmjs.com/package/@material-ui/x-license 🤷‍♂️

@oliviertassinari
Copy link
Member Author

@mbrookes Right, my bad. I should have been more precise. We need to add the license package as a dependency of x-grid and to not bundle it in the JavaScript asset.

@oliviertassinari oliviertassinari changed the title Yolo [DataGrid] Fix TypeScript definitions published on npm Sep 23, 2020
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! typescript and removed bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! typescript labels Sep 23, 2020
@oliviertassinari oliviertassinari mentioned this pull request Sep 23, 2020
Merged
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone Awaiting requested review from dtassone

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @mbrookes