Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove dead-code #353

Merged
merged 2 commits into from
Sep 28, 2020
Merged

[core] Remove dead-code #353

merged 2 commits into from
Sep 28, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 25, 2020 •
edited
Loading

The fewer dependencies in the array, the simpler to understand when it updates. Ref, setState, setReducer never change during a mount lifecycle.

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Sep 25, 2020
@dtassone
Copy link
Member

Are we testing the lint react effect rules?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 28, 2020 •
edited
Loading

Are we testing the lint react effect rules?

eslint-plugin-react-hooks is enabled. You can test that by breaking the rules in the source and see eslint exit 1.

@oliviertassinari oliviertassinari merged commit 1cfdada into mui:master Sep 28, 2020
@oliviertassinari oliviertassinari deleted the remove-dead-dependencies branch September 28, 2020 10:47
dtassone pushed a commit to dtassone/material-ui-x that referenced this pull request Nov 9, 2020
@oliviertassinari @dtassone
[core] Remove dead-code (mui#353)
ad5b3a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone dtassone approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @dtassone