[Storybook] fix warning and improve perf #407
Conversation
| @@ -24,10 +24,11 @@ module.exports = { | |||
| '@storybook/addon-a11y/register', | |||
| ], | |||
| typescript: { | |||
| check: __DEV__, // Netlify is breaking the deploy with this settings on. So deactivate on release | |||
| check: __DEV__, // Netlify is breaking the deploy with this settings on. So deactivate on release | |||
There was a problem hiding this comment.
AFAIK, this should be formated by prettier but isn't.
@eps1lon By default, we ignore dot files/folders, shouldn't set dot: true in the glob options?
There was a problem hiding this comment.
For prettier that makes sense, yes.
Edit: Probably makes sense for almost anything now that I think about it. Usually you want to ignore vendored files from these tasks. But not every dotfile is vendored. The only dotfile that is vendored is .yarn if I recall correctly.
There was a problem hiding this comment.
Ok, I will add it in the next batch of small changes. It should be a one-line change. Then, once committed we can benefit from it on material-ui-x.
There was a problem hiding this comment.
It should be a one-line change.
Those are usually the kind of changes the lead to days of work. At least I thought so in mui/material-ui#22814: Just bump the browser version and done 😆
| @@ -1,5 +1,4 @@ | |||
| import * as React from 'react'; | |||
| import { withA11y } from '@storybook/addon-a11y'; | |||
There was a problem hiding this comment.
Does it mean that we should remove @storybook/addon-a11y from the list of dependencies?
There was a problem hiding this comment.
Nope, we just don't need to declare it here
As mentioned, this PR fix all the warnings and improve the SB build time |
|
70+ sec down to 30 sec |
|
I have recently found https://vitro.now.sh/. I wonder if we shouldn't consider it as an alternative to Storybook. Vitro comes with Next.js built-in. Maybe it could nail the performance issue of Storybook. I mean: check this benchmark: https://www.webpagetest.org/video/compare.php?tests=201007_DiKP_23fb114e7e169261238c212e78d5b336,201007_DiBM_e569507ebd60a8b9e5075b8b479b3a07
Something could be improved |
Still very early stage |
|
Yeah, it's probably too early. |
* fix storybook perf and warning * fix perf on sourcemaps * improve build time
oliviertassinari
added
the
component: data grid
No description provided.