[docs] Fix duplicated Algolia records #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
fix-algolia-duplicate-records
branch
2 times, most recently
from
475073a to
96834b8
Compare
oliviertassinari
force-pushed
the
fix-algolia-duplicate-records
branch
from
96834b8 to
7955842
Compare
|
I can confirm the solution works. https://deploy-preview-419--material-ui-x.netlify.app/ outputs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pages are accessible through two different URLs:
This creates a duplicated record in Algolia's index when crawling our documentation.
To solve the problem, I'm creating a
nextbranch and a version of the source using v5, this will set https://github.com/mui-org/material-ui/blob/5af951be84e625eff6080b91ff5d6be28da4230b/docs/src/modules/components/Head.js#L33 which allows to disambiguate.Then, all we need to do is have
https://next.material-ui.com/proxyhttps://next--material-ui-x.netlify.app/instead of master. Done in mui/material-ui@bb0886a.