[DataGrid] Fix iOS issue when scrolling left #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
There was a problem hiding this comment.
What about the vertical scrolling?
I have left a couple of boy scout comments
packages/grid/_modules_/grid/hooks/virtualization/useVirtualRows.ts
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/hooks/virtualization/useVirtualRows.ts
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/hooks/virtualization/useVirtualRows.ts
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/hooks/virtualization/useVirtualRows.ts
Outdated
Show resolved
Hide resolved
dtassone
approved these changes
Oct 13, 2020
oliviertassinari
requested changes
Oct 13, 2020
I added additional check for vertical scrolling. It suffered from the same problem. |
oliviertassinari
approved these changes
Oct 15, 2020
packages/grid/_modules_/grid/hooks/virtualization/useVirtualRows.ts
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/hooks/virtualization/useVirtualRows.ts
Outdated
Show resolved
Hide resolved
…ws.ts Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
approved these changes
Oct 15, 2020
dtassone
pushed a commit
to dtassone/material-ui-x
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an iOS scroll stretching issue that is visible when the user tries to scroll left while the grid is at the left position of 0. The issue occurs because when you scroll on an IOS device a scroll event is fired even if there is no space to scroll in that direction (scroll bouncing).
The fix is achieved by checking the
event.target.scrollLeftand if it is < 0 prevent the update of the viewport.Fixes #269