Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve types #448

Merged
merged 2 commits into from
Oct 27, 2020
Merged

[core] Improve types #448

merged 2 commits into from
Oct 27, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 16, 2020 •
edited
Loading

  • A step closer to set "noImplicitAny": true, as best practice: https://material-ui.com/guides/typescript/.
  • Use this as an opportunity to centralize the tsconfig as much as possible (remove duplicates/dead options, remove inconsistencies).
  • TypeScript link storybook. It was disabled.

@oliviertassinari oliviertassinari changed the title use esm syntax [core] Use esm syntax Oct 16, 2020
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Oct 16, 2020
@oliviertassinari oliviertassinari force-pushed the fix-build branch 3 times, most recently from 3af4cfa to 96a3e90 Compare October 17, 2020 01:43
@oliviertassinari oliviertassinari changed the title [core] Use esm syntax [core] Refactoring Oct 17, 2020
@oliviertassinari oliviertassinari marked this pull request as ready for review October 17, 2020 01:56
@oliviertassinari oliviertassinari force-pushed the fix-build branch 4 times, most recently from 37e6750 to d54128f Compare October 17, 2020 14:11
@oliviertassinari oliviertassinari added typescript and removed bug 🐛 Something doesn't work labels Oct 17, 2020
@oliviertassinari oliviertassinari changed the title [core] Refactoring [core] noImplicitAny: true Oct 17, 2020
@oliviertassinari oliviertassinari force-pushed the fix-build branch 5 times, most recently from a078469 to 15cdf6f Compare October 17, 2020 15:47
@oliviertassinari oliviertassinari force-pushed the fix-build branch 4 times, most recently from 89cc73c to 77adf44 Compare October 17, 2020 16:13
dtassone
dtassone reviewed Oct 19, 2020
View reviewed changes
@oliviertassinari oliviertassinari changed the title [core] noImplicitAny: true [core] Improve types Oct 19, 2020
@oliviertassinari oliviertassinari mentioned this pull request Oct 20, 2020
Open
@oliviertassinari oliviertassinari force-pushed the fix-build branch 3 times, most recently from b3cc09b to 2f31e1c Compare October 24, 2020 16:19
@oliviertassinari oliviertassinari mentioned this pull request Oct 25, 2020
Merged
@oliviertassinari oliviertassinari merged commit f1835be into mui:master Oct 27, 2020
@oliviertassinari oliviertassinari deleted the fix-build branch October 27, 2020 13:49
dtassone pushed a commit to dtassone/material-ui-x that referenced this pull request Nov 9, 2020
@oliviertassinari @dtassone
[core] Improve types (mui#448)
2d3c40b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone dtassone approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @dtassone