Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Refactor columns scrolling #500

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

dtassone
Copy link
Member

@dtassone dtassone commented Oct 26, 2020

This PR is a refactoring that allows to sync the columns scrolling with the viewport scrolling and execute the scroll together.
It fixes a slight misalignment that can occur between frames

@dtassone dtassone changed the title refactor columns scrolling [DataGrid] refactor columns scrolling Oct 26, 2020
@oliviertassinari oliviertassinari changed the title [DataGrid] refactor columns scrolling [DataGrid] Refactor columns scrolling Oct 26, 2020
@oliviertassinari
Copy link
Member

Is there a context for the change?
I think that we should always attach a description to the pull requests we are working on. It can be a related issue, a link to a comment, a quick description, anything that describes the problem. It's important so we can scale the work to multiple people in the codebase, or even for you, in two years from now, when you want to blame the change :).

@oliviertassinari
Copy link
Member

Nice, it seems to help with this bug (this is on the branch, it's still visible but less :) ):

jump

@dtassone dtassone merged commit fb9fbf2 into mui:master Oct 27, 2020
dtassone added a commit to dtassone/material-ui-x that referenced this pull request Nov 9, 2020
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants