Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateRangePicker] Fix usage of maxDate / minDate / disableFuture and disablePast #5081

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 1, 2022

Fixes #5080

I think the code is self-explanatory
My bad on that one...

  • Test

We have almost no test for the disabled state (and none at all on DateRangePicker).
I added a few tests but we will have to add a lot more later.

@flaviendelangle flaviendelangle self-assigned this Jun 1, 2022
@flaviendelangle flaviendelangle added regression A bug, but worse component: DateRangePicker The React component. labels Jun 1, 2022
@mui-bot
Copy link

mui-bot commented Jun 1, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 259.5 568.6 415.9 388.9 116.57
Sort 100k rows ms 458.3 1,000.5 656.8 806.54 214.269
Select 100k rows ms 115.9 254.1 183.2 178.28 46.515
Deselect 100k rows ms 164.2 305.3 207.5 214.28 50.797

Generated by 🚫 dangerJS against ee5f2d8

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I let you open an issue requesting more tests on the date disabling behavior

@flaviendelangle flaviendelangle merged commit c2335b5 into mui:master Jun 2, 2022
@flaviendelangle flaviendelangle deleted the date-range-disable branch June 2, 2022 07:39
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DateRangePicker The React component. regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DateRangePicker] Can't disable dates
3 participants