Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Avoid paint step #531

Merged
merged 3 commits into from
Nov 4, 2020
Merged

[DataGrid] Avoid paint step #531

merged 3 commits into from
Nov 4, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 2, 2020 •
edited
Loading

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 2, 2020 •
edited
Loading

It seems that we are spending a bit less time in the painting phase and at least, we do no longer see the pain flash.

Before

Capture d’écran 2020-11-02 à 19 34 22

After

Capture d’écran 2020-11-02 à 19 34 07

@oliviertassinari oliviertassinari marked this pull request as ready for review November 2, 2020 18:39
@DanailH DanailH self-requested a review November 3, 2020 14:46
@oliviertassinari oliviertassinari merged commit 05ea7cc into mui:master Nov 4, 2020
@oliviertassinari oliviertassinari deleted the skip-paint branch November 4, 2020 09:58
dtassone pushed a commit to dtassone/material-ui-x that referenced this pull request Nov 9, 2020
@oliviertassinari @dtassone
[DataGrid] Avoid paint step (mui#531)
eb68352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

@dtassone dtassone Awaiting requested review from dtassone

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @DanailH