Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add more information to readme #539

Merged
merged 4 commits into from
Nov 6, 2020
Merged

[docs] Add more information to readme #539

merged 4 commits into from
Nov 6, 2020

Conversation

ankushchk
Copy link
Contributor

No description provided.

@oliviertassinari oliviertassinari changed the title add more information to readme [docs] Add more information to readme Nov 5, 2020
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 5, 2020
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. I have updated it to be closer to the readme of the main repository. We can't cover the data grid component specifically as this repository isn't only about the component, but all the other ones we are bringing.

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to the basic examples doesn't make much sense for the advanced components.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
For _how-to_ questions and other non-issues,
please use [StackOverflow](https://stackoverflow.com/questions/tagged/material-ui) instead of GitHub issues.
There is a StackOverflow tag called "material-ui" that you can use to tag your questions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to the paid version with reference to the included support?

Copy link
Member

@oliviertassinari oliviertassinari Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Pro" plan, the only one we sell yet, has no dedicated support attached to it. Proper support is in the "Premium" plan, and more expensive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe we can clarify it here, yes +1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Pro" plan, has no dedicated support attached to it

According to the wireframe it comes with a year of support.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to:

Capture d’écran 2020-11-05 à 21 34 09

in which I believe we provide support as GitHub issues :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So was I, but let's park it for another time.

Copy link
Member

@oliviertassinari oliviertassinari Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering "Pro" have priority over "Community" on GitHub, I 👍 the original comment.

Co-authored-by: Matt <github@nospam.33m.co>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Matt <github@nospam.33m.co>
@oliviertassinari oliviertassinari merged commit 2604808 into mui:master Nov 6, 2020
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Nov 7, 2020
dtassone pushed a commit to dtassone/material-ui-x that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants