Fix columns #542
Merged
Fix columns #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well it makes sense to call it on resize as columns look at the size of the grid, and the container state is changed according to the total column size... |
|
I'm merging this one as it's blocking all the other PRs, we can open an issue or investigate separately. |
|
… |
oliviertassinari
added a commit
that referenced
this pull request
Nov 6, 2020
This reverts commit 983d7aa.
Comment on lines
+235
to
+241
| const onResize = React.useCallback( | ||
| (size) => { | ||
| resetColumns(size.width); | ||
| }, | ||
| [resetColumns], | ||
| ); | ||
| useApiEventHandler(apiRef, RESIZE, onResize); |
There was a problem hiding this comment.
From what I understand gridState.containerSizes?.viewportSize.width already depends on the resize event, so this whole block is duplicated logic.
dtassone
added a commit
to dtassone/material-ui-x
that referenced
this pull request
Nov 9, 2020
* refactor columns * Fix columns test * remove dependency on viewport * fix test, reverted last commit
dtassone
pushed a commit
to dtassone/material-ui-x
that referenced
this pull request
Nov 9, 2020
This reverts commit 983d7aa.
zannager
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.